Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precise monad thunking #21

Merged
merged 1 commit into from
Dec 4, 2023
Merged

More precise monad thunking #21

merged 1 commit into from
Dec 4, 2023

Conversation

SkySkimmer
Copy link
Owner

Improves perf after #19

@SkySkimmer
More precise monad thunking
7bf6dc9 
Improves perf after #19
@SkySkimmer SkySkimmer mentioned this pull request Dec 4, 2023
Merged
@SkySkimmer SkySkimmer merged commit 8e17108 into main Dec 4, 2023
1 check passed
@SkySkimmer SkySkimmer deleted the better-thunking branch December 4, 2023 16:21
@Janno
Copy link

Janno commented Dec 4, 2023

This is indeed a huge improvement. I don't have numbers for only the Ltac2 code but for our slowest file the overall numbers I have are:

No compilation: 650s
With #19, #20: 560s (~30s out of that is compilation time)
With #19, #20, and #21: 500s, (~20s compilation time)

@Janno Janno mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkySkimmer @Janno