Monad-thunk every nontrivial nontac_expr #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #17 I am not fully sure that this is a compiler bug as the ~~~ocaml let l = List.map (fun f -> Proofview.tclIGNORE (thaw f)) l in ~~~ in the implementation of `dispatch` could also be blamed for not thunking properly (ie should be ~~~ocaml let l = List.map (fun f -> tclUNIT () >>= fun () -> tclIGNORE (thaw f)) l in ~~~ ) but it does seem hard or impossible to trigger a bug with non compiled ltac2. This change does cause some slowdown (bug_10107 goes from 0.04s to 0.06s, non compiled baseline being 0.25s)
also about doubles timings in tests/minibench (still much faster than non compiled) |
|
Would fixing the code in Coq reduce the performance overhead of this change? |
|
IDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17
I am not fully sure that this is a compiler bug as the
in the implementation of
dispatchcould also be blamed for not thunking properly (ie should be) but it does seem hard or impossible to trigger a bug with non compiled ltac2.
This change does cause some slowdown (bug_10107 goes from 0.04s to 0.06s, non compiled baseline being 0.25s)