Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audible beep after an import? #168

Open
jimfoltz opened this issue Feb 17, 2017 · 5 comments
Open

Audible beep after an import? #168

jimfoltz opened this issue Feb 17, 2017 · 5 comments

Comments

@jimfoltz
Copy link
Contributor

Would it be super annoying to UI.beep (option) after a long import?

@thomthom
Copy link
Member

hmm...

I can see the use for long imports. Maybe conditional after x amount of time considered "long"?

@thomthom
Copy link
Member

Somewhat related to this - in terms of "long import". I was testing some files and I got annoyed by the repair feature which kicks. Useful some times - but some times I don't care about repairing.

So I made an option to turn of repair; https://github.com/thomthom/sketchup-stl/tree/dev-repair-option

Haven't made a PR out of it though.

@jimfoltz
Copy link
Contributor Author

I have had the same thought. I will fetch from your repo, merge and try a PR.

@jimfoltz
Copy link
Contributor Author

jimfoltz commented Feb 17, 2017

I think I'll remove the display of the import time out of the repair option PR, and maybe add a "show summary" option. Using a UI.messagebox will also take care of the beep.

@thomthom
Copy link
Member

The import time in that branch was just for development - as I was testing performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants