fix #1165: insert mode lag #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultisnips was traversing the whole runtimepath every time an expansion was attempted, something that happens for every key press since there is autotrigger. Even without autotrigger, traversal was done at every snippet expansion, which caused slowdowns in that case. With this change, traversal happens only the first time, or after a source must be refreshed (because a snippets file has been updated).
|
That would be a great improvement! Looking at the tests it seems you deterministically broke on. Will you have a look at that? |
|
The test |
Force a refresh also for the FileType autocommand.
|
Should be fixed now, it was broken because it only worked for the first loaded filetype. |
And move the autocommand into the autoload file.
Just let ensure() run.
Remove the underscore since it's accessed in the manager class.
|
@mg979 Thanks for working on this, Gianmaria! This was a common complaint and I never found the time to track it down. Your work is very appreciated and thanks for fixing the tests! |
|
The initial commit broke proper snippets loading actually, not just tests. I think #1496 could also be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultisnips was traversing the whole runtimepath every time an expansion was attempted, something that happens for every key press since there is autotrigger.
Even without autotrigger, traversal was done at every snippet expansion, which caused slowdowns in that case.
With this change, traversal happens only the first time, or after a source must be refreshed (because a snippets file has been updated).
Note: I cannot run tests (Windows).