Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #149

Open
farisshajahan opened this issue May 2, 2021 · 3 comments
Open

Update README #149

farisshajahan opened this issue May 2, 2021 · 3 comments

Comments

@farisshajahan
Copy link
Contributor

The default profile being used for the application runtime is local. The README also does not mention setting the profile at runtime to anything else. However, local has sms.enabled=true but does not mention how a developer can set up their credentials for the same. This leads to an error while running saying FCM Credentials are not found. The Dockerfile specifies the usage of the dev profile for running the application. I think the README should be updated with the same or mention how a user can set up the credentials.

@daltonfury42
Copy link
Collaborator

Hmm. To me, setting sms.enabled to false in local properties file here seems to be the best approach. What do you think?

FCM based notification is not yet production ready, so I don't want to include it in readme. We might remove it in the future if it didn't work for us.

@farisshajahan
Copy link
Contributor Author

farisshajahan commented May 2, 2021

Sure. Switching to false should work. I guess devs could manually set it to true when they work with the SMS service and use MockSMS at all other times.
On a different note though, is there any reason there are two profiles (dev and local) both of which seem to be for development environments?

@daltonfury42
Copy link
Collaborator

I don't know how it is being used now, but the original idea was to have local for local development, dev and prod as two hosted environments. But now we don't have dev running anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants