Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CMake #306

Open
1 task done
ktbolt opened this issue Nov 26, 2024 · 0 comments
Open
1 task done

Clean up CMake #306

ktbolt opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ktbolt
Copy link
Collaborator

ktbolt commented Nov 26, 2024

Use Case

Building svFSIplus.

Problem

While slogging through the CMake code to rename svFSIplus I've realized that the CMake code is much more complicated than it needs to be.

It seems that the CMake code that was taken from svFSI was itself copied over from svSolver which was copied from SimVascular (?).

For example Externals: there are no externals and yet there is a directory for this with a CMakeLists.txt file with the comments

#-----------------------------------------------------------------------------
# This is SimVascular's CMakeLists.txt for downloading/building the externals
# needed for SimVacular. Pre-built binaries are only available for certain
# versions of the libraries on certain operating systems. To build your own,

I'm sure that it should not take 3000 lines of CMake code to build a simple application using a few internal packages.

Solution

Simplify the CMake code.

Alternatives considered

Don't simplify the CMake code.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@ktbolt ktbolt added the enhancement New feature or request label Nov 26, 2024
@ktbolt ktbolt self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant