Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Prompt Selection Not Working Correctly #8

Open
stars-blue2081 opened this issue Dec 18, 2024 · 1 comment
Open

Custom Prompt Selection Not Working Correctly #8

stars-blue2081 opened this issue Dec 18, 2024 · 1 comment
Assignees

Comments

@stars-blue2081
Copy link

stars-blue2081 commented Dec 18, 2024

Description

There are two related UI/functionality issues when working with custom prompts:

  1. UI Display Issue:

    • When clicking "Edit Prompt", the recently made Custom Prompt appears
    • However, the default prompts are shown instead of the custom ones
    • Temporary fix: Switching between default and custom prompt fixes the display
  2. Prompt Injection Issue:

    • The default Injected Prompt is being used instead of the custom one
    • Default Injected Prompt being sent: "Your current task is [{{task}}]. Balance existing roleplay with completing this task."
    • The custom Injected Prompt is not being used despite being selected from "Edit Prompt"

Expected Behavior

  • The selected custom prompt's Injected Prompt should be used instead of the default one

Current Behavior

  • When tapping on the "Save Prompt", the button looks like this:
    Screenshot_20241218_114211_Chrome
  • UI shows wrong prompts initially but fixes itself when switching between default/custom
  • Task placeholders work correctly
  • Default Injected Prompt is being sent instead of the custom one (confirmed via Prompt Inspector and cmd window)
@Cohee1207 Cohee1207 self-assigned this Dec 21, 2024
Cohee1207 added a commit that referenced this issue Dec 21, 2024
@Cohee1207
Copy link
Member

Confirmed, this part was in a rather broken state, I tried my best to make sense of it.

  1. Made the prompts actually restore from the metadata on load.
  2. The selection of the custom prompt set now persists per-chat.
  3. "Save Prompt" renamed to "Update Prompt" to better reflect what it does.
  4. Fixed edits to custom prompts not persisting upon page reload.
  5. Slightly redesigned the editor popup with more 'logical' layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants