-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polls / New features #166
Comments
[POLL] docker-machine is deprecated. I was thinking of removing support for it. Make some noise if you disagree 😉 |
Re-adding support for |
There are alive fork of docker-machine maintained by gitlab. It will be nice if you restore support for it, but makes it optional. |
@codewylle interesting, but it still does not support json in their Go template format. This makes it a pain because we have to handle it separatly , and apparently you seem to be the only user. foo@host:~$ ./docker-machine-Linux-x86_64 ls --format="{{ .Id }}"
foo@host:~$ ./docker-machine-Linux-x86_64 ls --format="{{ json .Id }}"
template: :1: function "json" not defined But if it's valuable to you I can help you in making it a standalone package that you could maintain? |
@Silex thank you for readying to help. I will try to. How can I inject docker-machine to docker transient? |
@codewylle: let's continue in #168 |
Support for "devcontainers.json" ?
https://code.visualstudio.com/docs/remote/devcontainerjson-reference I think Emacs should have a way to handle it in some form. (= build the Docker image it "describes")
|
@behrica: That looks like a lot of work. What support do you have in mind? It's the first time I encounter it. |
I only think about a small subset, of "fields" from the devcontainer.json file Firstly there is an existing cli tool, which should be "called" from emacs: https://code.visualstudio.com/docs/remote/devcontainer-cli This does a big chunk of the work already. This is the "first stage build".
-> 5 times "docker exec ..." and the there are some options, which "configure" how the final "docker run" is executed:
I have initial code for this, which basically is a sequence of calls (5 or 6) to "docker .... This would therefore simulate what VSCode does when it "builds and starts" a devcontainer from a devcontainer.json file. I was starting to build this as a standalone CLI tool (which maybe makes more sense) Curious about any comment from your side. |
Continuing in #174 |
Option to use vterm (full-blown terminal emulator) with various commands. |
Just a heads-up: I'm working on the async implementation and I found aio which produce very clean code (compare https://github.com/Silex/docker.el/blob/aio/docker-network.el#L90-L94 vs https://github.com/Silex/docker.el/blob/async/docker-network.el#L115-L128 (the comparison is not completely fair but you get the idea: waiting on multiple callbacks is a pain in vanilla emacs)). The thing is aio needs Emacs 26, so that means docker.el will require Emacs 26. It's probably not a big deal for anyone but I was surprised in the past so let's see what happens 😆 |
Funny, because podman recently implemented new things to it's "podman machine" calls. For example, look at https://github.com/containers/podman/releases/ and you see in Podman v4.1.0 from May 2022 you see several enhancements to "podman machine". Personally I don't care about this poll entry, as I don't use "podman machine". |
support for |
something to inspect layers; https://github.com/wagoodman/dive does this, sometimes handy for checking sizes (I have no idea how complex it would be, just throwing the idea out here since this seemed like the right place) |
This issue is there for when we need feedback on the package's direction.
Feel free to subscribe/unsubscribe from it.
The text was updated successfully, but these errors were encountered: