Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how xlsx-renderer handle vertical merged cells inside loops #95

Open
Siemienik opened this issue Jul 9, 2020 · 6 comments
Open

Fix how xlsx-renderer handle vertical merged cells inside loops #95

Siemienik opened this issue Jul 9, 2020 · 6 comments
Assignees
@Siemienik
Labels
accepted It is accepted to do BUG Something isn't working important Do it first

Comments

@Siemienik
Copy link
Owner

Siemienik commented Jul 9, 2020 •
edited
Loading

all files are available in 9a87732

Actual

image.png

Expected

image.png
Siemienik referenced this issue in Siemienik/xlsx-renderer Jul 21, 2020
@Siemienik
WIP: #37 added test case wich works wrong for further investigation
9a87732
@Siemienik
Copy link
Owner Author

Vertically merged cells in loop do not work perfectly as can be seen in 9a87732.

@Siemienik Siemienik self-assigned this Jul 21, 2020
@Siemienik Siemienik changed the title Check vertical merged cells inside loops Fix vertical merged cells inside loops Jul 21, 2020
@Siemienik Siemienik transferred this issue from Siemienik/xlsx-renderer Nov 19, 2020
@Siemienik Siemienik added accepted It is accepted to do BUG Something isn't working labels Nov 19, 2020
@Siemienik Siemienik changed the title Fix vertical merged cells inside loops Fix how xlsx-renderer handle vertical merged cells inside loops Dec 16, 2020
@Siemienik Siemienik moved this from Accepted to Important in My Open Source Software Activities Nov 17, 2021
@Siemienik Siemienik added the important Do it first label Nov 17, 2021
@skypesky
Copy link

skypesky commented Feb 1, 2022

@Siemienik
This question looks interesting,
Is there any code that repeats this bug?

@Siemienik
Copy link
Owner Author

Siemienik commented Feb 1, 2022 •
edited
Loading

Hi @skypesky. I'm glad that you're asking.

Yes, the reproduction could be found in this commit: Siemienik/xlsx-renderer@9a87732

You can run these test fixtures with the current codebase by putting them into the integration tests: https://github.com/Siemienik/XToolset/tree/master/packages/xlsx-renderer/tests/integration/data

@skypesky
Copy link

skypesky commented Feb 7, 2022

@Siemienik
I ran the branch test and have seen the error. f/37-vertical-merged-cells.
The implementation of this part seems to be the most complex(ForeachCell). I plan to spend some time studying it.

@Siemienik
Copy link
Owner Author

I'll keep my fingers crossed. if any help is needed you can find me as always on the Gitter

@skypesky skypesky removed their assignment Apr 23, 2022
@thanh-withcoverage
Copy link

Hi @Siemienik any updates on this topic? I'm facing ugly/unstable render for vertical merged cell. I would like to achieve something like in the image.
image

My template:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siemienik Siemienik

Labels
accepted It is accepted to do BUG Something isn't working important Do it first
Projects
My Open Source Software Activities
Status: Important
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Siemienik @skypesky @thanh-withcoverage