Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test examples on each push event #65

Open
6 of 25 tasks
Siemienik opened this issue Oct 24, 2020 · 0 comments
Open
6 of 25 tasks

Test examples on each push event #65

Siemienik opened this issue Oct 24, 2020 · 0 comments
Labels
accepted It is accepted to do important Do it first

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 24, 2020

Examples

The existence of examples has two reasons:

  1. Show others how to use our pretty lib
  2. Prove that this lib works with different envs&technologies

The situation when one of the examples stop works, and we don't know about it is unacceptable. So has to add a job which will test all of them automatically for each push event.

However, we have two situations when tests should work a little bit different.

  1. The first one, if code inside ./sample changed: should install xlsx-import version from ./sample/*/package-lock.js and then run tests
  2. The second situation if this lib code was changed (./src), then should install xlsx-import version by commit hash using git+https protocol.

TODO list:

general

  1. Add job 'Prepare samples list':
    1. read samples/* dir names as json array and set into output
  2. Add job if src and samples were both changed
  3. Investigate how to get a table of supported browsers & versions for Vue and React sample

situation 1:

  1. Add job 'Samples (npm)'
    • Set strategy.samples with names of samples (fromJson)
    • For each:
      • install dependencies
      • run npm test

situation 2:

  1. Add job 'Samples (master) '
    • Set strategy.samples with names of samples (fromJson)
    • For each:
      • install dependencies
      • install xlsx-import from current repo/branch (ref)
      • run npm test

samples/xlsx-import+express

  1. Mock npm test
  2. Add npm test script which checks API response
  3. Add info about testing into Readme

samples/xlsx-import+react

  1. Add info about testing into Readme

samples/xlsx-import+vue

  1. Add info about testing into Readme

samples/xlsx-import+nodejs

  1. Add npm test script which checks API response DONE in: Add test command for nodejs and nodejs-ts samples + upgrade  #74
  2. Add info about testing into Readme DONE in: Add test command for nodejs and nodejs-ts samples + upgrade  #74

samples/xlsx-import+nodets

  1. Add npm test script which checks API response DONE in: Add test command for nodejs and nodejs-ts samples + upgrade  #74
  2. Add info about testing into Readme DONE in: Add test command for nodejs and nodejs-ts samples + upgrade  #74

samples/xlsx-import-cli

  1. Mock npm test
  2. Add npm test script which checks examples
  3. Add info about testing into Readme
@Siemienik Siemienik changed the title DRAFT: [CI] Run tests for samples on GH action workflow [CI] Run tests for samples on GH action workflow Oct 25, 2020
@Siemienik Siemienik changed the title [CI] Run tests for samples on GH action workflow Ci: Run tests for samples on GH action workflow Nov 1, 2020
@Siemienik Siemienik added accepted It is accepted to do not ready yet Needs precision important Do it first and removed accepted It is accepted to do labels Nov 1, 2020
@Siemienik Siemienik changed the title Ci: Run tests for samples on GH action workflow [Draft] Ci: Run tests for samples on GH action workflow Jan 22, 2021
@Siemienik Siemienik changed the title [Draft] Ci: Run tests for samples on GH action workflow Test examples on each push event Jan 24, 2021
@Siemienik Siemienik added accepted It is accepted to do and removed not ready yet Needs precision labels Jan 24, 2021
@Siemienik Siemienik removed the important Do it first label Feb 11, 2021
@Siemienik Siemienik added the important Do it first label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It is accepted to do important Do it first
Projects
Status: Important
Development

No branches or pull requests

1 participant