Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports path #34

Open
Siemienik opened this issue Oct 9, 2020 · 0 comments
Open

Imports path #34

Siemienik opened this issue Oct 9, 2020 · 0 comments
Labels
accepted It is accepted to do

Comments

@Siemienik
Copy link
Owner

Actual

As it can be seen in samples/nodejs/importer.js:

https://github.com/Siemienik/xlsx-import/blob/ba224a5d0572c6f63a7bb27cee4833da80fb3ef9/samples/nodejs/importer.js#L1

It is required to use long path. It is absolutely unwanted.

Expected

const { ImporterFactory, Importer } = require('xlsx-import');
const { MAPPER_DEFAULT } = require('xlsx-import/mappers');

it means that the default package dir shoul be set as ./lib.

KEEP backward compatibility: It needs an investigate how to keep backward capability for some time before the change is finally committed and old paths stop working.
@Siemienik Siemienik added accepted It is accepted to do important Do it first labels Nov 1, 2020
Siemienik added a commit that referenced this issue Nov 8, 2020
@Siemienik
Merge pull request #34 from Siemienik/f/14-node-versions-supported
48008a5 
Increase node-version range to cover 6x-14x
@Siemienik Siemienik removed the important Do it first label Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted It is accepted to do
Projects
My Open Source Software Activities
Status: Accepted
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Siemienik