Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging cell address into console.log inside CellTemplateDebugPool.match() #134

Closed
Siemienik opened this issue Jan 15, 2021 · 0 comments · Fixed by #150
Closed

Add logging cell address into console.log inside CellTemplateDebugPool.match() #134

Siemienik opened this issue Jan 15, 2021 · 0 comments · Fixed by #150
Assignees
@Siemienik
Labels
accepted It is accepted to do good first issue Good for newcomers

Comments

@Siemienik
Copy link
Owner

Siemienik commented Jan 15, 2021 •
edited
Loading

When I tried to fix the code that was not working, I see that the debug option does not log essential information like cell address. Please to add cell.address into CellTemplateDebugPool's console log.

refs:
#93 (comment)
https://github.com/jacekkoziol/xlsx/pull/1/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R64

    // todo @siemienik, add logging cell address into console.log inside CellTemplateDebugPool.match();
@Siemienik Siemienik added good first issue Good for newcomers accepted It is accepted to do labels Jan 15, 2021
@Siemienik Siemienik self-assigned this Jan 31, 2021
Siemienik added a commit that referenced this issue Jan 31, 2021
@Siemienik
Log full cell address if Debug
fd96df2 
resolves: #134
@Siemienik Siemienik mentioned this issue Jan 31, 2021
Merged
Siemienik added a commit that referenced this issue Feb 1, 2021
@Siemienik
Log full cell address if Debug (#150)
e946e5e 
* Log full cell address if Debug
resolves: #134

* Improve tests performance by running once integration test for a debug option.
@Siemienik Siemienik mentioned this issue Feb 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siemienik Siemienik

Labels
accepted It is accepted to do good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log full cell address if Debug Siemienik/XToolset
1 participant
@Siemienik