Merge pull request #69 from skiritsa/master

Fix ignore configuration when we use increment_build_number or increment_app_version in xcodeproj with target and build_configuration_name
SiarheiFedartsou · Jun 25, 2022 · 44c1929 · 44c1929
2 parents ec13234 + e67c2da
commit 44c1929
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/lib/fastlane/plugin/versioning/actions/increment_build_number_in_xcodeproj.rb b/lib/fastlane/plugin/versioning/actions/increment_build_number_in_xcodeproj.rb
@@ -59,10 +59,16 @@ def self.set_build_number_using_target(params, next_build_number)
           target = project.targets[0] if target.nil?
         end
 
-        target.build_configurations.each do |config|
+        if params[:build_configuration_name]
+          config = target.build_configurations.detect { |c| c.name == params[:build_configuration_name]}
           UI.message "updating #{config.name} to build #{next_build_number}"
           config.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
-        end unless target.nil?
+        else
+          target.build_configurations.each do |config|
+            UI.message "updating #{config.name} to build #{next_build_number}"
+            config.build_settings["CURRENT_PROJECT_VERSION"] = next_build_number
+          end unless target.nil?
+        end
 
         project.save
       end

diff --git a/lib/fastlane/plugin/versioning/actions/increment_version_number_in_xcodeproj.rb b/lib/fastlane/plugin/versioning/actions/increment_version_number_in_xcodeproj.rb
@@ -79,10 +79,17 @@ def self.set_version_number_using_target(params, next_version_number)
           target = project.targets[0] if target.nil?
         end
 
-        target.build_configurations.each do |config|
+        if params[:build_configuration_name]
+          config = target.build_configurations.detect { |c| c.name == params[:build_configuration_name]}
           UI.message "updating #{config.name} to version #{next_version_number}"
           config.build_settings["MARKETING_VERSION"] = next_version_number
-        end unless target.nil?
+        else
+          target.build_configurations.each do |config|
+            UI.message "updating #{config.name} to version #{next_version_number}"
+            config.build_settings["MARKETING_VERSION"] = next_version_number
+          end unless target.nil?
+        end
+
 
         project.save
       end