Extend OpenAPI docs for bus API #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/bus-api-spec
branch
from
95bccf3 to
231abdb
Compare
| metric := jc.PathParam("key") | ||
| if metric == "" { | ||
| jc.Error(errors.New("parameter 'metric' is required"), http.StatusBadRequest) | ||
| key := jc.PathParam("key") |
There was a problem hiding this comment.
I wonder if this is even possible considering it's a path param. If key is "", then the path would be different and the router would probably return a 404 before even calling the handler.
| @@ -2806,6 +5502,140 @@ components: | |||
| description: The total amount of memory available in bytes | |||
| minimum: 1 | |||
|
|
|||
| MultipartUpload: | |||
There was a problem hiding this comment.
This seems to be unused. Same for MultipartListPartItem, MultipartCompletedPart and Sector
|
@ChrisSchinnerl now has all routes, would like to F/U with a PR where I go over all routes in an editor and see what's missing |
ChrisSchinnerl
force-pushed
the
pj/bus-api-spec
branch
from
1d8db55 to
add448e
Compare
ChrisSchinnerl
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes added:
/contract/hosts/host/metric/multipart/objects/object/params/slabbuffers/sectors/settings/slabs/state/stats/system/upload/webhooks