Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent named imports for RHP packages #1678

Open
ChrisSchinnerl opened this issue Nov 18, 2024 · 0 comments
Open

Consistent named imports for RHP packages #1678

ChrisSchinnerl opened this issue Nov 18, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone
v2.1.0

Comments

@ChrisSchinnerl
Copy link
Member

Right now we use rhp, rhpvX, rhpX and potentially other names pretty inconsistently for importing the paths
go.sia.tech/core/rhp/vX, go.sia.tech/coreutils/rhp/vX and go.sia.tech/renterd/internal/rhp/vX.

We should correct that to be consistent about the name each import gets. I think outside of renterd we are mostly consistent so it's a good idea to check the other repos first and reuse the conventions if possible.
@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Nov 18, 2024
@ChrisSchinnerl ChrisSchinnerl moved this from Triage to Backlog in Sia Nov 18, 2024
@ChrisSchinnerl ChrisSchinnerl added the good first issue Good for newcomers label Nov 18, 2024
@ChrisSchinnerl ChrisSchinnerl added this to the v2.1.0 milestone Nov 18, 2024
@ChrisSchinnerl ChrisSchinnerl mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Sia
Status: Backlog
Milestone
v2.1.0
Development

No branches or pull requests
1 participant
@ChrisSchinnerl