From f963bc176334af40ed06b7bbfa3a901a47b3f2a6 Mon Sep 17 00:00:00 2001
From: Chris Schinnerl <chris@sia.tech>
Date: Thu, 19 Dec 2024 16:53:59 +0100
Subject: [PATCH] speed up gouging test

---
 internal/test/e2e/cluster.go      |  2 +-
 internal/test/e2e/gouging_test.go | 21 ++++++++++++++++-----
 internal/test/e2e/host.go         |  1 +
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/internal/test/e2e/cluster.go b/internal/test/e2e/cluster.go
index 9564e046f..bc4dacda7 100644
--- a/internal/test/e2e/cluster.go
+++ b/internal/test/e2e/cluster.go
@@ -639,7 +639,7 @@ func addStorageFolderToHost(ctx context.Context, hosts []*Host) error {
 // the group
 func announceHosts(hosts []*Host) error {
 	for _, host := range hosts {
-		settings := defaultHostSettings
+		settings := host.settings.Settings()
 		settings.NetAddress = host.rhp4Listener.Addr().(*net.TCPAddr).IP.String()
 		if err := host.UpdateSettings(settings); err != nil {
 			return err
diff --git a/internal/test/e2e/gouging_test.go b/internal/test/e2e/gouging_test.go
index dc52a39f7..7689f4e27 100644
--- a/internal/test/e2e/gouging_test.go
+++ b/internal/test/e2e/gouging_test.go
@@ -24,9 +24,20 @@ func TestGouging(t *testing.T) {
 	w := cluster.Worker
 	tt := cluster.tt
 
-	// add hosts
+	// add hosts with short price table validity to speed up test
+	gs, err := b.GougingSettings(context.Background())
+	tt.OK(err)
+	gs.MinPriceTableValidity = api.DurationMS(10 * time.Second)
+	tt.OK(cluster.bs.UpdateGougingSettings(context.Background(), gs))
+
 	n := int(test.AutopilotConfig.Contracts.Amount)
-	tt.OKAll(cluster.AddHostsBlocking(n))
+	for i := 0; i < n; i++ {
+		h := cluster.NewHost()
+		settings := h.settings.Settings()
+		settings.PriceTableValidity = time.Duration(gs.MinPriceTableValidity)
+		h.UpdateSettings(settings)
+		cluster.AddHost(h)
+	}
 	cluster.WaitForAccounts()
 
 	// assert all hosts are usable
@@ -66,7 +77,7 @@ func TestGouging(t *testing.T) {
 	tt.OK(cluster.hosts[0].UpdateSettings(updated))
 
 	// update gouging settings
-	gs := test.GougingSettings
+	gs = test.GougingSettings
 	gs.MaxStoragePrice = settings.StoragePrice
 	if err := b.UpdateGougingSettings(context.Background(), gs); err != nil {
 		t.Fatal(err)
@@ -74,13 +85,13 @@ func TestGouging(t *testing.T) {
 
 	// make sure the price table expires so the worker is forced to fetch it
 	// again, this is necessary for the host to be considered price gouging
-	time.Sleep(defaultHostSettings.PriceTableValidity)
+	time.Sleep(time.Duration(gs.MinPriceTableValidity))
 
 	// assert all but one host are usable
 	h, err = b.UsableHosts(context.Background())
 	tt.OK(err)
 	if len(h) != n-1 {
-		t.Fatal("unexpected number of hosts", len(h))
+		t.Fatal("unexpected number of hosts", len(h), n-1)
 	}
 
 	// upload some data - should fail
diff --git a/internal/test/e2e/host.go b/internal/test/e2e/host.go
index fe673fa46..948f91fa8 100644
--- a/internal/test/e2e/host.go
+++ b/internal/test/e2e/host.go
@@ -222,6 +222,7 @@ func NewHost(privKey types.PrivateKey, cm *chain.Manager, dir string, network *c
 		settings.WithRHP2Port(uint16(rhp2Listener.Addr().(*net.TCPAddr).Port)),
 		settings.WithRHP3Port(uint16(rhp3Listener.Addr().(*net.TCPAddr).Port)),
 		settings.WithRHP4Port(uint16(rhp4Listener.Addr().(*net.TCPAddr).Port)),
+		settings.WithInitialSettings(defaultHostSettings),
 	)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create settings manager: %w", err)