Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostd should not allow you to announce without a port. #204

Closed
skunk-ink opened this issue Nov 5, 2023 · 2 comments
Closed

Hostd should not allow you to announce without a port. #204

skunk-ink opened this issue Nov 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@skunk-ink
Copy link

Current Behavior

It is possible to announce your host without a port. This should not be allowed to avoid new user frustrations.

Expected Behavior

A user should not be allowed to announce without setting a port. It might be good to even have it default to the port 9982 if one wasn't specified and confirm with the user that is the port they would like to announce on. There should also be a little information icon that tells users they should be announcing the RHP2 port which is 9982 by default.

Steps to Reproduce

  1. Announce without a port number specified

Version

V2.0

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Ubuntu Server 22.04 LTS

Anything else?

No response

@skunk-ink skunk-ink added the bug Something isn't working label Nov 5, 2023
@n8maninger
Copy link
Member

n8maninger commented Nov 5, 2023

This is fixed by #195, will release v0.2.1 soon

@skunk-ink
Copy link
Author

Ah awesome. I tried looking to see if it was addressed or not but missed it. I'm updating the docs to specify that this needs to be done as well 👍

@n8maninger n8maninger added this to Sia Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Triage in Sia Mar 14, 2024
@n8maninger n8maninger moved this from Triage to Done in Sia Mar 14, 2024
@n8maninger n8maninger moved this from Done to Released in Sia Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants