-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host benchmarking #122
Comments
Not sure if it's planned already. But it would be helpful to be able to benchmark hosts while reusing the existing contract, unlike benchyd where each benchmark creates a new contract. |
From a cost perspective I think it makes sense to have that as the goal. |
I disagree. Stick with simplicity and do a short contract with 1 benchmark = 1 contract. Cost difference is negligible, but the implementation is significantly simpler when you can assume a new contract will need to be formed and you don't need to manage existing contracts. |
@n8maninger could you elaborate how the cost is negligible to create a new contract every time? I did 2 benchmarks, one with 1 sector and one with 10 sectors. It looks like the the cost difference isn't too much. Both around 0.27SC Running 10 benchmarks with each their own contract would cost around 2.7SC. If a single contract 10x the size would barely make a difference compared to a single contract, how would reusing contracts not make a significant difference? Another thing. I feel like I would be spamming the blockchain a lot if I wouldn't reuse contracts. If I were to benchmark all hosts for example 4 times a day, with 500 hosts I would be creating 60K contracts a month, with roughly 4K of them active at a time. That's more than 10% of the current active contracts on the entire network. I'm still a newbie on this side, any feedback/elaboration is welcome :) |
Looking at both of those contracts, the second one has about 10x more spent than the first. Most of the cost seems to be coming from the Siafund tax on the host's collateral, which looks like it is calculated inefficiently/incorrectly. However, it's still pretty negligible. Spamming the blockchain isn't too terribly concerning. Onboarding more renters means more active contracts too, so I generally consider that a good thing. Having said that, I would consider the goals when trying to benchmark the whole network 4x a day. Providing trends over a longer period of time will likely provide just as useful data than frequent benchmarks over such a short period. Also significantly increases infrastructure requirements as the network grows. It's probably fine at 500 hosts, but what about 5000? |
Thanks for the explanation. The decimal place threw me off. Would've probably been better to use a different amount of sectors than 10 😛 As described in my grant request, I want to build a system to check hosts on interval and warn them if there are any issues. I might stick to only running benchmarks on hosts that subscribed to alerts. |
No description provided.
The text was updated successfully, but these errors were encountered: