Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision proof output regression #116

Closed
n8maninger opened this issue Oct 16, 2024 · 0 comments · Fixed by #117
Closed

Revision proof output regression #116

n8maninger opened this issue Oct 16, 2024 · 0 comments · Fixed by #117
Assignees
Milestone

Comments

@n8maninger
Copy link
Member

n8maninger commented Oct 16, 2024

Looks like we had a regression in [GET] /contracts/:id/revisions endpoint. The valid and missed proof outputs are null.

[
	{
		"resolved": false,
		"valid": false,
		"transactionID": "txid:6461a72dbf77fbc2c96a9c612588fe67f4676147533bd0659281d451cf0f6dbd",
		"confirmationIndex": {
			"height": 92047,
			"id": "bid:000000001930ffcdb085351da16dc75284bbeaa5ce6153bc9198767c63cca195"
		},
		"confirmationTransactionID": "txid:6461a72dbf77fbc2c96a9c612588fe67f4676147533bd0659281d451cf0f6dbd",
		"proofIndex": null,
		"proofTransactionID": null,
		"id": "h:297c732023cff1b85b3b24576e90c72408f47e0781135e57d07877d6b22f69c5",
		"leafIndex": 0,
		"fileContract": {
			"filesize": 49064968192,
			"fileMerkleRoot": "h:1df90858aab6ed5d02a73dd222c80b27240090b4f63df11bd12d7160a24ac0c9",
			"windowStart": 99740,
			"windowEnd": 99884,
			"payout": "360858723096877312247100398",
			"validProofOutputs": null,
			"missedProofOutputs": null,
			"unlockHash": "h:6b0fc922a18f7463148ce513cf5415898b0b7b45d6edd0ff862d740dfbfc3bca",
			"revisionNumber": 0
		}
	},
...
]

https://api.beta.siascan.com/zen/api/contracts/9bae51b6a9c305c96058c226e8d76a681ee4cbc62af0052c3933c06c20fc9c35/revisions

@n8maninger n8maninger added this to Sia Oct 16, 2024
@n8maninger n8maninger moved this to Todo in Sia Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Sia Oct 16, 2024
@n8maninger n8maninger added this to the v0.1.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants