From eab17228ef11482abc18adffc551c74af02bd852 Mon Sep 17 00:00:00 2001 From: Alex Freska <alex.freska@gmail.com> Date: Tue, 30 Jan 2024 16:26:07 -0400 Subject: [PATCH] add s3 bucket secrets --- .github/workflows/pr.yml | 4 ---- .github/workflows/publish.yml | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 546bd08..7cb5de1 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -70,8 +70,6 @@ jobs: run: yarn workspace ${{ matrix.app }} build shell: bash - name: Package executable bundles, make distributables - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: yarn workspace ${{ matrix.app }} make shell: bash windows: @@ -91,8 +89,6 @@ jobs: run: yarn workspace ${{ matrix.app }} build shell: bash - name: Package executable bundles, sign and notarize, make distributables - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | yarn workspace ${{ matrix.app }} make # #TODO: probably not correct diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 93d8217..88b6cf6 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -54,6 +54,8 @@ jobs: APPLE_API_KEY: ${{ secrets.APPLE_API_KEY }} APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }} APPLE_API_KEY_PATH: ${{ env.APPLE_API_KEY_PATH }} + BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }} + BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: yarn workspace ${{ matrix.app }} publish shell: bash @@ -73,6 +75,8 @@ jobs: shell: bash - name: Package executable bundles, make and publish distributables env: + BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }} + BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: yarn workspace ${{ matrix.app }} publish shell: bash @@ -94,6 +98,8 @@ jobs: shell: bash - name: Package executable bundles, sign and notarize, make and publish distributables env: + BUCKET_ACCESS_KEY_ID: ${{ secrets.BUCKET_ACCESS_KEY_ID }} + BUCKET_SECRET_ACCESS_KEY: ${{ secrets.BUCKET_SECRET_ACCESS_KEY }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | yarn workspace ${{ matrix.app }} publish