Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch wallet updates into a single database transaction #39

Closed
n8maninger opened this issue Mar 18, 2024 · 0 comments
Closed

Batch wallet updates into a single database transaction #39

n8maninger opened this issue Mar 18, 2024 · 0 comments

Comments

@n8maninger
Copy link
Member

n8maninger commented Mar 18, 2024 •
edited
Loading

#26 changed how chain updates are managed. We can replace wallet.ApplyChainUpdates and wallet.RevertChainUpdate with a single function that processes all updates atomically. That should increase performance for some stores.

coreutils/wallet/update.go

Line 147 in c73e571

func ApplyChainUpdates(tx ApplyTx, address types.Address, updates []chain.ApplyUpdate) error {

coreutils/wallet/update.go

Line 246 in c73e571

func RevertChainUpdate(tx RevertTx, address types.Address, cru chain.RevertUpdate) error {

@n8maninger n8maninger added this to Sia Mar 18, 2024
@github-project-automation github-project-automation bot moved this to Triage in Sia Mar 18, 2024
@ChrisSchinnerl ChrisSchinnerl moved this from Triage to Todo in Sia Mar 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Sia Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n8maninger