Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdRegister offset #76

Open
themperek opened this issue Dec 14, 2017 · 7 comments
Open

StdRegister offset #76

themperek opened this issue Dec 14, 2017 · 7 comments
Labels
Milestone

Comments

@themperek
Copy link
Member

As pointed by @hansk68 offset should point to LSB and not to MSB position.
Changing this will break a lot of compatibilities.

Options:

Comments welcome.

@laborleben
Copy link
Collaborator

This is an old discussion...

We use offset in HL.RegisterHardwareLayer in the sense of LSB position.

I'd recommend to stick with "offset" and fix the behavior. You can implement error checks for the offset and throw an error with a meaningful error message.

@themperek
Copy link
Member Author

For v2.5.0? It may lead to compatibility issues at the begining.

@laborleben
Copy link
Collaborator

So, do we add a new class for that?

@themperek
Copy link
Member Author

This seems ok. To FieldRegister or just Register?

@laborleben
Copy link
Collaborator

I vote for Register

@themperek
Copy link
Member Author

I started to work on this for 3.0.

There is one complication. At the moment, repeat in StdRegister put element 0 on left (MSB) side of the array and I think to be consistent it should be on the right (LSB) of the array so I am planning to change this in new Register class too.
Any opinion on this @laborleben @thirono @MarcoVogt

@themperek themperek added this to the 3.0.0 milestone Jan 7, 2019
@laborleben
Copy link
Collaborator

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants