Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to CONTRIBUTE? #50

Open
findel opened this issue Oct 27, 2016 · 6 comments
Open

How to CONTRIBUTE? #50

findel opened this issue Oct 27, 2016 · 6 comments

Comments

@findel
Copy link
Contributor

findel commented Oct 27, 2016

Could you add a contribution / build document?

I'd like to work on this using VS Code, but I'm having trouble getting it set up correctly to build/compile.

@ShyykoSerhiy
Copy link
Owner

ShyykoSerhiy commented Oct 27, 2016

Of course. I'm going to make it more "contributable" this Saturday along with added tests, contribution guide and some refactoring.

@findel
Copy link
Contributor Author

findel commented Oct 27, 2016

Brill. I think I've got it working now.

It was not finding the typings/index.d.ts file.

I needed to npm install typings -g and then run typings install debug --save.

Now it seems to be compiling to JavaScript in dist, but I get errors like these:

src/contacts_service.ts(1,26): error TS2307: Cannot find module 'request'.
src/contacts_service.ts(5,23): error TS2307: Cannot find module 'http'.
src/contacts_service.ts(6,25): error TS2307: Cannot find module 'request'.

Can I fix those?

@ShyykoSerhiy
Copy link
Owner

That's strange.
All you need to do is

git clone https://github.com/ShyykoSerhiy/skyweb.git
cd ./skyweb
npm i
npm i -g typings typescript
typings install
tsc 

There should be no errors.

@ShyykoSerhiy
Copy link
Owner

It's typings install debug --save line that's wrong. You need 'typings install'. It restores typings that are provided in typings.json file. typings install debug --save actuall install typings for debug package and adds it to typings.json file. Hope this helps.

@findel
Copy link
Contributor Author

findel commented Nov 1, 2016

Yup, that's good. I've got it building okay now. Thanks.

@qvaqvaboo
Copy link

qvaqvaboo commented Nov 15, 2016

Reproduces for me:

git clone https://github.com/ShyykoSerhiy/skyweb.git
cd ./skyweb
npm i
npm i -g typings typescript
typings install
tsc 

Results in:
error TS6053: File '/skyweb/typings/index.d.ts' not found.

Had to do
typings install debug --save
first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants