Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does it bundle koichisasada.vscode-rdbg when Shopify.ruby-lsp supports debugging? #579

Closed
Nowaker opened this issue Feb 3, 2024 · 3 comments

Comments

@Nowaker
Copy link

Nowaker commented Feb 3, 2024

This is really unclear. Shopify.ruby-lsp supports debugging. And this extension pack depends on koichisasada.vscode-rdbg. So what should I use to debug? Shopify.ruby-lsp or koichisasada.vscode-rdbg? If the answer is Shopify.ruby-lsp, then this plugin should no longer bundle koichisasada.vscode-rdbg. And if the answer is koichisasada.vscode-rdbg, then why does Shopify.ruby-lsp support debugging?

@vinistock
Copy link
Member

Thank you for the question.

The Ruby LSP's debugger client doesn't yet support all features available in RDBG. We started out with some of the main debugging flows, especially so that we could connect the debug code lens that appear on tests to the debugger client.

Eventually, when the Ruby LSP matches feature parity, we can remove RDBG from the extension pack.

Meanwhile, if the Ruby LSP is sufficient for your needs and you haven't found an RDBG feature we don't support, you can uninstall RDBG and the extension pack will not automatically re-install it.

@Nowaker
Copy link
Author

Nowaker commented Feb 5, 2024

Thank you for your explanation, @vinistock. Perhaps this type of explanation could be included in the pack's description?

Also, since koichisasada.vscode-rdbg doesn't tap directly into Shopify.ruby-lsp's Ruby version manager detection system, bundler support etc, perhaps the readme of this plugin could include a launch.json example to use when coupled with Shopify.ruby-lsp?

@vinistock
Copy link
Member

Perhaps this type of explanation could be included in the pack's description?

Sure, I think that's a good addition.

...perhaps the readme of this plugin could include a launch.json example to use when coupled with Shopify.ruby-lsp?

The Ruby LSP doesn't interact with RDBG in any way. I think RDBG specific documentation should probably be centralized in its own repo.

That said, we can definitely include a link to their documentation in our explanation of the debugger clients.

Let me know if you're interested in putting a PR up for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants