Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting breaks on non-Spinel themes #578

Closed
noahgregory-basis opened this issue Feb 1, 2024 · 1 comment
Closed

Syntax highlighting breaks on non-Spinel themes #578

noahgregory-basis opened this issue Feb 1, 2024 · 1 comment

Comments

@noahgregory-basis
Copy link

After reading #562, I was a bit concerned about using these extensions for general development, but they appear fine to use right now. I've just noticed, though, syntax highlighting sometimes breaks in other color themes. Below is a Regexp to match a Japanese date format in the built-in Red color theme. It does not appear like this without the Ruby extensions installed. To note, the Spinel themes that comes with the extensions do not appear to have this issue.

Screenshot 2024-02-01 at 17 10 12
@vinistock vinistock closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@vinistock
Copy link
Member

I was a bit concerned about using these extensions for general development, but they appear fine to use right now

They are all for general development.

though, syntax highlighting sometimes breaks in other color themes.

It's not related to themes, it's actually a bug with handling multibyte characters: Shopify/ruby-lsp#1162. You can see that the highlighting is offset by a few characters, which is the number of extra bytes in the Japanese characters.

I'll close this issue to keep discussions centralized in that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants