Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bricks color theme #561

Closed
h0jeZvgoxFepBQ2C opened this issue Nov 23, 2023 · 6 comments
Closed

bricks color theme #561

h0jeZvgoxFepBQ2C opened this issue Nov 23, 2023 · 6 comments

Comments

@h0jeZvgoxFepBQ2C
Copy link

Hi,

I'm using this color theme: https://github.com/mrded/vscode-theme-railscasts

and after enabling the Shopify ruby extension it bricks my color theme?

How can I disable the override over my colortheme?

@vinistock
Copy link
Member

Hello! What do you mean with "bricks my color theme"?

The Ruby LSP provides semantic highlighting information, which might change how the theme highlights your code - especially if it does not take semantic information into account.

@h0jeZvgoxFepBQ2C
Copy link
Author

it should look like this (Ruby LSP disabled):
Bildschirmfoto 2023-11-23 um 15 56 36

But with Ruby LSP enabled it looks like this (all colors are broken somehow):
Bildschirmfoto 2023-11-23 um 15 55 45

Is it possible to stop somehow the color changes?

@vinistock
Copy link
Member

You can configure the Ruby LSP and turn off semantic highlighting if you wish.

The reason the colours all seem the same is likely because the theme is not using the semantic information to highlight the code.

For example, method declarations and invocations use the method.declaration and method semantic tokens, respectively. If the theme doesn't differentiate based on semantic token modifiers, then it's likely assigning the same colour to both token types.

All that is to say, if the theme started handling the Ruby LSP's semantic information, it would likely look significantly better.

@vinistock vinistock closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2023
@h0jeZvgoxFepBQ2C
Copy link
Author

Yeah i tried and even disabled all features, but it still overwrites (also after window reloading) my theme?

@h0jeZvgoxFepBQ2C
Copy link
Author

Bildschirmfoto 2023-11-23 um 16 12 19

@vinistock
Copy link
Member

Do you have any other Ruby related extensions installed? It might be the grammar file bundled in Ruby LSP, but that's the same grammar file that was previously bundled in Rebornix Ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants