Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconstent line references in check-shims #1803

Open
andyw8 opened this issue Feb 23, 2024 · 0 comments
Open

Inconstent line references in check-shims #1803

andyw8 opened this issue Feb 23, 2024 · 0 comments
Labels
good-first-issue Good for newcomers rubyconf-hackday

Comments

@andyw8
Copy link
Contributor

andyw8 commented Feb 23, 2024

Minor nit:

Duplicated RBI for ::RubyVM::YJIT::enabled?:
 * https://github.com/sorbet/sorbet/tree/master/rbi/core/ruby_vm.rbi#L804
 * sorbet/rbi/shims/core/ruby_vm.rbi:5:4-5:26

Should we output the second entry as sorbet/rbi/shims/core/ruby_vm.rb#5? I don't think the column numbers are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers rubyconf-hackday
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyw8 @egiurleo