Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update shopify app express and sql lite session storage #1343

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Oct 29, 2024

WHY are these changes introduced?

After this release of many js npm packages, we should update the dependencies to their latest versions.

WHAT is this pull request doing?

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-node#andy-liuu/update-dependencies

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@andy-liuu andy-liuu requested a review from a team as a code owner October 29, 2024 15:17
@andy-liuu andy-liuu self-assigned this Oct 29, 2024
@andy-liuu andy-liuu merged commit 7db9849 into main Oct 29, 2024
8 checks passed
@fullstackdeveloper918
Copy link

After this change. I am unable to generate access token in sqlite for custom server. it was working fine before this change.

@andy-liuu
Copy link
Contributor Author

@fullstackdeveloper918

Thank you for flagging this! Could you please create an issue with reproduction steps? This will help us investigate and resolve the bug more effectively.

@fullstackdeveloper918
Copy link

Earlier I was using this template to build our all shopify public apps. I am using vultr.com server to host the app. From last week whenever I am trying to install app using custom redirect urls, access token is not getting stored in SQLITE. without access token app is not working. We have no option to stop using node template now.

@lizkenyon
Copy link
Contributor

Hey @fullstackdeveloper918!

Sorry to hear you have run into this issue. We would love to try to investigate it further!

If you could create an issue with example code that would allow us to reproduce the issue, that would allow us to investigate further! Our initial test on a fresh app template did not reproduce the issue.

@fullstackdeveloper918
Copy link

There is no need to send any code, video. I am not using my app which I built with yiur app just to make sure wther it is my code issue or template's issue. I am using exact same sample app'code,It is very first step. this issue comes with installation. First we start with normal commands you mentioned in readme file. When we go with normal cloudflare urls which app generate automatically, it gets installed on one store and stores access token in sqlite.
2nd time, I have to change my redirect urls, application urls so I can recieve access token on my server. After updating my server urls it never store any access token in sqlite DB. I am not doing any mistake in settings. I have same access scopes, valid working redirect urls, valid apiKEY and Secret.
You can easily replicate issue by trying app on custom linux server with ubuntu 22.04 version and nginx server.

@lizkenyon
Copy link
Contributor

lizkenyon commented Nov 12, 2024

2nd time, I have to change my redirect urls, application urls

To clarify are you saying that when you are in local development using a cloudflare tunnel the installation works correctly. But when you are running your application in production, and update to the production application URLs that is when the app is not installing correctly?

updating my server urls it never store any access token in sqlite DB.

If you turn on debug logging are you seeing any errors in the terminal? Are you seeing any errors in the UI during install? Does your app show as installed in the list of installed apps in the Shopify Admin?

@fullstackdeveloper918
Copy link

fullstackdeveloper918 commented Nov 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants