Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Shipit::Task::PRESENCE_CHECK_TIMEOUT for each Shipit::Task #1381

Open
mfilipe opened this issue Nov 21, 2024 · 1 comment
Open

Change Shipit::Task::PRESENCE_CHECK_TIMEOUT for each Shipit::Task #1381

mfilipe opened this issue Nov 21, 2024 · 1 comment

Comments

@mfilipe
Copy link
Contributor

mfilipe commented Nov 21, 2024

What is the best way to override the Shipit::Task::PRESENCE_CHECK_TIMEOUT constant on a per-task basis?

I need to adjust the PRESENCE_CHECK_TIMEOUT value for specific Shipit::Task because one type of task is raising an Background job hasn't reported back... error due to a Kubernetes finalizer taking more than 30 seconds (default) to finish.

What is the most effective approach to achieve this without affecting other tasks globally?

@mfilipe
Copy link
Contributor Author

mfilipe commented Nov 21, 2024

Another useful solution could be to force the task run again. Today, the task runs, get timeout and doesn't try to re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant