Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server telemetry #650

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Remove server telemetry #650

merged 1 commit into from
Sep 25, 2023

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Apr 21, 2023

Motivation

The client side is implemented in Shopify/vscode-ruby-lsp#571.

Doing benchmarks in the server itself is not reliable and doesn't include the entire roundtrip that requests make until they are processed in the editor.

Additionally, benchmarking stuff on the server means it will spend time sending telemetry events to the client for every single request and notification.

Implementation

  1. Stopped sending telemetry/event notifications completely
  2. Started returning error information as part of the request response, which we can read in the client

Automated Tests

Adjusted the related tests for the removed functionality.

@vinistock vinistock added the enhancement New feature or request label Apr 21, 2023
@vinistock vinistock added this to the 2023-Q2 milestone Apr 21, 2023
@vinistock vinistock requested a review from a team as a code owner April 21, 2023 21:05
@vinistock vinistock self-assigned this Apr 21, 2023
@andyw8
Copy link
Contributor

andyw8 commented Jun 13, 2023

Moving to backlog as discussed at team meeting on 2023-06-12.

@vinistock vinistock modified the milestones: 2023-Q2, 2023-Q3 Jul 10, 2023
@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Jul 20, 2023
@vinistock vinistock force-pushed the vs/refactor_telemetry branch from 7d4468a to f0f2e5f Compare September 21, 2023 15:33
@Shopify Shopify deleted a comment from github-actions bot Sep 21, 2023
@vinistock vinistock merged commit ad3c909 into main Sep 25, 2023
28 of 30 checks passed
@vinistock vinistock deleted the vs/refactor_telemetry branch September 25, 2023 13:56
vinistock added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants