Make the extension's test suite less dependent on individual setups #2877
Labels
chore
Chore task
Comments
adam12
added a commit
to adam12/ruby-lsp
that referenced
this issue
Nov 28, 2024
Not all non-Shopify developer environments have a version of shadowenv installed. In those circumstances, skip the suite with a console warning. Part of Shopify#2877
adam12
added a commit
to adam12/ruby-lsp
that referenced
this issue
Nov 28, 2024
Not all non-Shopify developer environments have a version of shadowenv installed. In those circumstances, skip the suite with a console warning. Part of Shopify#2877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the extension's test suite makes several assumptions about what is going to be available in the user's machine. For example, the Shadowenv test assumes that it will be available and the chruby test assumes rubies will be available in certain locations.
This is not friendly to external contributors who may not have their environments configured similarly to our team. Let's ensure that the test suite skips tests that cannot be executed. Let's also try to ensure that we can run as many tests as possible locally.
The text was updated successfully, but these errors were encountered: