Remove deprecated experimental features from global state #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
the
server
Graphite App
vinistock
added
the
breaking-change
Graphite App
andyw8
requested changes
Nov 19, 2024
andyw8
approved these changes
Nov 19, 2024
|
Where is this listed in the docs? |
|
|
Those are not tied to the setting. We just advertise them as experimental since they are not yet complete. |
vinistock
deleted the
11-05-remove_deprecated_experimental_features_from_global_state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we're moving forward with feature flags, we should remove the old experimental features setting to avoid confusion. This PR removes it from the server.
Implementation
We didn't have any active experimental features, so I just removed the handling of the initialization option and the associated test.