-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support module_function in the indexer #2733
Support module_function in the indexer #2733
Conversation
4cc387f
to
045ec92
Compare
There are some typecheck failures. |
Hi @andyw8, Thank you for reviewing! I pushed a new commit, fixed the type check failures, and signed off on the CLA. Do I have to commit "I have signed the CLA!" to rerun the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
Let's also add a fixture for (I was surprised to see that Prism doesn't have one already). |
Do we need one given that we have the unit test?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Motivation
Closes #2653
The
module_function
invocation creates both a singleton method and a private method when usinginclude
in a class. The indexer needs to account for this behavior by mutating the method's visibility and handling both method types.Implementation
When the indexer encounters a
module_function
, it updates the corresponding method entry:Automated Tests
Add a new test