Raise if scanner cannot find requested position #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Open
|
Not clear if this actually helps diagnose. Closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to understand #2446
This PR starts raising if the document scanner cannot find the requested position. It prints both the document state and the requested position, so that we can understand if the document state got corrupted or if the requested position doesn't make sense.
Implementation
If we exceed the search loop, but the request line is still different than the one we found, then we couldn't find the correct position and we can raise.
This is not the solution for the problem, it's just a way to diagnose it.
Automated Tests
Added a test.