Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block highlights to the usual highlights #2494

Closed
1 task done
frandegrandis opened this issue Aug 27, 2024 · 1 comment · Fixed by #2779
Closed
1 task done

Add block highlights to the usual highlights #2494

frandegrandis opened this issue Aug 27, 2024 · 1 comment · Fixed by #2779
Assignees
@rogancodes
Labels
enhancement New feature or request help-wanted Extra attention is needed

Comments

@frandegrandis
Copy link

I have checked that this feature is not already implemented

  • This feature does not exist

Use case

It would be great to be able to see where some particular block starts and ends, this would be useful to understand with some messy files what are we looking into or when defining some test with describes to understand where some particular describe ends, can be also done with folding ranges but i feel is useful to have this one. Left some images with examples, i think this can be an improvement on the document highlighting

Image

Image

Image

Image

Image

Description

Something similar to document highlighting but for the blocks.
When the cursor is over this "block starters" to highlight the corresponding end.

Implementation

No response
@frandegrandis frandegrandis added the enhancement New feature or request label Aug 27, 2024
@st0012 st0012 added the help-wanted Extra attention is needed label Aug 30, 2024
@st0012 st0012 removed their assignment Aug 30, 2024
@rogancodes
Copy link
Contributor

Hi Team, Im looking at this issue.

@rogancodes rogancodes mentioned this issue Oct 25, 2024
Merged
vinistock pushed a commit that referenced this issue Nov 4, 2024
@rogancodes
Highlight definition and control block structures (#2779)
d4064db 
### Motivation

Closes #2494

### Implementation

If the cursor is on a definition or control node, both the start and end of the node will be highlighted.

### Automated Tests

Amended existing test case.

### Manual Tests

Place the cursor on one of the definition or control nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogancodes rogancodes

Labels
enhancement New feature or request help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight definition and control block structures rogancodes/ruby-lsp
3 participants
@st0012 @frandegrandis @rogancodes