Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention minimum required dependent gem versions #1795

Closed
onyxraven opened this issue Apr 3, 2023 · 3 comments · Fixed by #2828
Closed

Mention minimum required dependent gem versions #1795

onyxraven opened this issue Apr 3, 2023 · 3 comments · Fixed by #2828
Labels
documentation Improvements or additions to documentation good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale transferred This issue was transferred from vscode-ruby-lsp

Comments

@onyxraven
Copy link

onyxraven commented Apr 3, 2023

When working with an existing project which has rubocop in its Gemfile, it needs to be a compatible version, or a user gets this error message:

Error running diagnostics: Incompatible RuboCop version. Ruby LSP requires >= 1.4.0

It looks like this comes from ruby-lsp but it doesn't mention it in readme/docs directly either.

jayanth-kumar-morem referenced this issue in jayanth-kumar-morem/vscode-ruby-lsp Apr 26, 2023
…est-0.28.0

Bump rubocop-minitest from 0.27.0 to 0.28.0
@vinistock vinistock added documentation Improvements or additions to documentation good-first-issue Good for newcomers help-wanted Extra attention is needed labels May 2, 2023
@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Jul 20, 2023
@st0012 st0012 transferred this issue from Shopify/vscode-ruby-lsp Mar 18, 2024
@st0012 st0012 added the transferred This issue was transferred from vscode-ruby-lsp label Mar 18, 2024
@vinibispo
Copy link
Contributor

@vinistock, Where would be a great place to put this info?

@vinistock
Copy link
Member

I'd say we can put it in a new sub section under usage. Maybe call it implicit dependencies.

We only have one (RuboCop), but there's no existing place to put it, so I think it warrants a new section.

@andyw8
Copy link
Contributor

andyw8 commented Nov 5, 2024

Let's also add a comment in the code where we specify the minimum version, as a reminder to update the docs if we ever bump the minimum version..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale transferred This issue was transferred from vscode-ruby-lsp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants