Return empty diagnostics result if there are no syntax errors and rubocop isn't installed #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think you need a rebase. |
catlee
force-pushed
the
catlee/empty_diagnostics
branch
from
407c442 to
705361b
Compare
rubocop isn't installed
catlee
force-pushed
the
catlee/empty_diagnostics
branch
from
705361b to
261a463
Compare
st0012
reviewed
Jan 9, 2024
st0012
approved these changes
Jan 10, 2024
|
Amazing work @catlee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In neovim/neovim#26640 we discovered that
ruby-lspsometimes sends back a nil response totextDocument/diagnostic.I tracked this down to when we have a syntactically valid file, and we don't have
rubocopavailable, then the diagonstic code returnsnil.According to the LSP spec, we should return an empty array in this case.
Implementation
Return an empty array if we don't have
Support::RuboCopDiagnosticsRunnerAutomated Tests
I added some tests here, but not sure if the way I'm manipulating the
Supportmodule is good.I also noticed that the number of diagnostics we get back from the tests varies; sometimes we get back just rubocop diagnostics, and sometimes we get back rubocop + sorbet diagnostics.