Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename server extensions to addons #1033

Closed
vinistock opened this issue Sep 22, 2023 · 2 comments · Fixed by #1035
Closed

Rename server extensions to addons #1033

vinistock opened this issue Sep 22, 2023 · 2 comments · Fixed by #1035
Assignees
Milestone

Comments

@vinistock
Copy link
Member

In hindsight, using the name server extensions was not a good choice as it leads to confusion with VS Code extensions. There's no easy way to refer to them without saying "Ruby LSP server extensions".

Plugin may also lead to confusion given that, in editors other than VS Code, that's often the term used to describe their "extensions". Like Vim plugins.

Let's rename server extensions to addons. The name is descriptive enough and not overloaded with other meanings that could lead to confusion.

This will be a breaking change, but it's better we do this now than after there's a larger ecosystem of gems adding Ruby LSP functionality.

@vinistock vinistock added this to the 2023-Q3 milestone Sep 22, 2023
@andyw8
Copy link
Contributor

andyw8 commented Sep 22, 2023

addon or add-on? 😁

FWIW, Mozilla uses the hyphen: Add-ons

@vinistock
Copy link
Member Author

I don't have a strong preference for documentation. I feel like the biggest decision is the class name and how we refer to it in code.

# Do we want this
class Addon
  def register_addon
  end
end

# Or do we want
class AddOn
  def register_add_on
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants