From d10405127e34b179bf0a93a06fd07df4f7e5cee3 Mon Sep 17 00:00:00 2001 From: Andy Waite <13400+andyw8@users.noreply.github.com> Date: Tue, 17 Dec 2024 17:12:05 -0500 Subject: [PATCH] Lower to typed true since we don't have all sigs --- .rubocop.yml | 1 + lib/ruby_lsp/test_helper.rb | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 2ba910dcb..4fc414f9d 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -60,6 +60,7 @@ Sorbet/StrictSigil: - "lib/ruby_indexer/lib/ruby_indexer/prefix_tree.rb" - "lib/ruby_lsp/load_sorbet.rb" - "lib/ruby_lsp/scripts/compose_bundle.rb" + - "lib/ruby_lsp/test_helper.rb" Layout/ClassStructure: Enabled: true diff --git a/lib/ruby_lsp/test_helper.rb b/lib/ruby_lsp/test_helper.rb index 2cbb225af..0fee56218 100644 --- a/lib/ruby_lsp/test_helper.rb +++ b/lib/ruby_lsp/test_helper.rb @@ -1,4 +1,4 @@ -# typed: strict +# typed: true # frozen_string_literal: true # NOTE: This module is intended to be used by addons for writing their own tests, so keep that in mind if changing. @@ -65,8 +65,6 @@ def pop_result(server) end end - # TODO: write correct sig - sig { params(message_queue: T.untyped, type: T.untyped).returns(T.untyped) } def pop_log_notification(message_queue, type) log = message_queue.pop return log if log.params.type == type @@ -75,8 +73,6 @@ def pop_log_notification(message_queue, type) log end - # TODO: write correct sig - sig { params(outgoing_queue: T.untyped, block: T.untyped).returns(T.untyped) } def pop_message(outgoing_queue, &block) message = outgoing_queue.pop return message if block.call(message)