From ad782750e92e5454cc22a335d91785a3c899990e Mon Sep 17 00:00:00 2001 From: Andy Waite Date: Wed, 27 Nov 2024 09:44:02 -0500 Subject: [PATCH] Add note to PR template (#2922) * Add note to PR template * Copy note to Contributing doc --- .github/pull_request_template.md | 4 ++++ jekyll/contributing.markdown | 3 +++ 2 files changed, 7 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a8a6b8163..1eb0974a8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,7 @@ + + ### Motivation diff --git a/jekyll/contributing.markdown b/jekyll/contributing.markdown index 3cbaa717f..cd8f21c48 100644 --- a/jekyll/contributing.markdown +++ b/jekyll/contributing.markdown @@ -6,6 +6,9 @@ nav_order: 50 # Contributing +{: .note } +> If you plan to invest significant effort into a large pull request with multiple decisions that may impact the long term maintenance of the Ruby LSP, please open a [discussion](https://github.com/Shopify/ruby-lsp/discussions/new/choose) first to align on the direction. + The [ruby-lsp repository](https://github.com/Shopify/ruby-lsp) contains three sub-projects: - the **language server** (`ruby-lsp`), which exists at the top level of the repository. Most features are implemented here since everything implemented in the server is available to all editors