-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0alpha] send login (=customerAccessToken) to checkout page #430
Comments
Hi @formatlos, if you append We're making some changes to |
Oh thanks for the fast reply, that sounds great. The Login-Button seems to be gone already. When do you think is the |
The checkout page already consumes the We'll make the change for the |
Doesn't seem to work for my shop. Does this only work for new shops? |
Ah sorry, I disabled it for testing something and forgot to turn it back on again. Thanks a lot, you're awesome |
Glad it's all sorted out :). |
@formatlos is this sorted out for you? |
@naiduasn yes it did work in the end, not sure if that's still the case though. |
@naiduasn @formatlos I haven't been able to get it working, I think it may have been deprecated? assigned the checkout instance to the customer and passed same token through to the weburl but login still shows. |
The use of |
I disagree. Sensitive data is a Secret, something that should be on the server side. Once you log in (in any site, mind you), you receive an access token (that's how JWT works, basically) therefore it stops being sensitive, as it's already in the user's control (on their browser). I don't see how passing a token that you already have is a security vulnerability. How is JWT secure, then? Even better, how do you consider the Storefront API being secure if it also uses a token that's on the client side? Receiving a token from a request and having a token in the source files received by the server is the same thing, you just reach one from Chrome's Network tab and the other one through the Sources tab. I really fail to see the logic behind this reasoning. |
For headless frontend this can be done only one way (for September 2022) - using Multipass. The task is: we have a separate frontend app which communicates with Shopify through Storefront API and allows users to select goods and place them into the cart with API calls to mutations cartCreate/cartLinesAdd/cartLinesUpdate (we are using cart object, not checkout object). The solution: So, this is part of frontend to get special checkoutUrl:
And this is a part of our backend (nodejs + express), using multipassify npm package (recommended by Shopify: https://shopify.dev/api/multipass#example-implementation):
Hope, this will help someone looking for solution. |
Yo thank you so much bro. That will works with new Remix Hydrogen with some customize |
This is probably a little off-topic here, but as the next version of the js-buy-sdk internally also uses the graphql endpoints I thought I might at least find someone who has some more insights in the internals. I already posted the problem in the official forum, but even after a few weeks nobody answered my question.
How can I send the
customerAccessToken
I get with logging in via API (=customerAccessTokenCreate
) to the checkout page to log the user in?As I'm building a completely custom storefront, logging in again via the 'normal' Shopify login form is not an option.
Is there some hidden query param I have to send or is this something which is not possible at all? I'd really appreciate talking to an actual developer at shopify because all the so called experts and the forum is not very helpful.
The text was updated successfully, but these errors were encountered: