RedisRequestLogger in RequestLogsFeature does not support NamespacePrefix #60
-
According to the online documentation https://docs.servicestack.net/request-logger#redis-request-logger settings, but Logging No Results Environment:
Example code/Steps to reproduce:
Output:
Bug Analysis: The ServiceStack.Redis connection string sets the NamespacePrefix to "ServiceStack:", but the Log method of the ServiceStack.Host.RedisRequestLogger.cs class does not process the NamespacePrefix. So the cache key saved in Redis's Zset is wrong, for example: "urn:requestlogentry:1" is wrong, the correct one should be: "ServiceStack:urn:requestlogentry:1" |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
I've changed it to use Anyway this change is available in the latest v6.8.1 on MyGet. |
Beta Was this translation helpful? Give feedback.
I've changed it to use
redis.UrnKey<T>
in this commit to be more consistent, butNamespacePrefix
does not provide "true" keyspace partitioning and any change to existing behavior can result in breaking changes, so we'll be reluctant in making changes where there's a potential for breaking changes. You can submit PRs to propose changes which we can evaluate on a per change basis.Anyway this change is available in the latest v6.8.1 on MyGet.