Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Require linting to pass before merging #54

Open
jlamypoirier opened this issue Nov 20, 2024 · 0 comments
Open

[feat] Require linting to pass before merging #54

jlamypoirier opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jlamypoirier
Copy link
Collaborator

🧐 Problem Description

We need to tell every new contributor to setup pre-commit.

💡 Proposed Solution

  • Add pre-commit requirement to contributing guidelines, maybe also to the PR template.
  • Add a pre-commit test to CI
  • Require CI to pass before merging (need to fix the flaky docker build first though)
@jlamypoirier jlamypoirier added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlamypoirier