Fix for Python 3.10 Callable move to collections.abc #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this code locally on my machine and can confirm it resolved the issues I was seeing. (Tools page effectively unresponsive, Python error output to Octoprint console). I'm not sure how Octoprint and plugins support backwards compatibility, it might be worth checking |
|
I have the exact same issue which is kind of blocking and was considering raising a similar pull review. Would be great if it could be merged indeed! EDIT: I have checkout-ed your code and it fixes my issue ; I can calibrate my printer again :) |
|
This fixed my issues as well. Good catch ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31
The m92 command wasn't being sent/working anymore