Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc flags not appropriate #254

Open
Tux opened this issue Sep 8, 2020 · 0 comments
Open

gcc flags not appropriate #254

Tux opened this issue Sep 8, 2020 · 0 comments

Comments

@Tux
Copy link

Tux commented Sep 8, 2020

zstd/Makefile adds a truckload of CFLAGS that are only applicable if the compiler is GNU gcc, but cause epic failure when it is not, like when using HP C-ANSI-C on HP-UX.
Please guard that against non-gcc compilers. Our live is hard enough as it is and use $Config{cflags} instead. On HP-UX I would use something like -Ae +DD64 -z +Z (where +Z is the equiv of -fPIC)
FWIW this is in both Sereal::Encoder and Sereal::Decoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant