From 1f46a9615c08a0bd17e4d7af691e93ca3669798a Mon Sep 17 00:00:00 2001 From: vjetteam Date: Thu, 26 Jul 2012 11:20:52 -0700 Subject: [PATCH 1/7] Update ux/TreePicker.js https://sencha.jira.com/browse/VJET-5 convert @private to @public since overriding is trying to reduce visibility of method --- ux/TreePicker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ux/TreePicker.js b/ux/TreePicker.js index e587fe1..a0f4c52 100644 --- a/ux/TreePicker.js +++ b/ux/TreePicker.js @@ -70,7 +70,7 @@ Ext.define('Ext.ux.TreePicker', { /** * Creates and returns the tree panel to be used as this field's picker. - * @private + * @public */ createPicker: function() { var me = this, @@ -133,7 +133,7 @@ Ext.define('Ext.ux.TreePicker', { /** * Aligns the picker to the input element - * @private + * @public */ alignPicker: function() { var me = this, From 348c76770f36c75d8499ee00573072359a1b42f3 Mon Sep 17 00:00:00 2001 From: vjetteam Date: Thu, 26 Jul 2012 11:23:09 -0700 Subject: [PATCH 2/7] Update ux/grid/filter/DateFilter.js https://sencha.jira.com/browse/VJET-5 convert @private to @public since overriding is trying to reduce visibility of method --- ux/grid/filter/DateFilter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ux/grid/filter/DateFilter.js b/ux/grid/filter/DateFilter.js index 95941f8..630ca43 100644 --- a/ux/grid/filter/DateFilter.js +++ b/ux/grid/filter/DateFilter.js @@ -223,7 +223,7 @@ Ext.define('Ext.ux.grid.filter.DateFilter', { }, /** - * @private + * @public * Template method that is to return true if the filter * has enough configuration information to be activated. * @return {Boolean} From 148abbcf068bee9c05f6d55f889ff5a903160acc Mon Sep 17 00:00:00 2001 From: vjetteam Date: Thu, 26 Jul 2012 11:25:49 -0700 Subject: [PATCH 3/7] Update ux/grid/filter/NumericFilter.js @private to @public overriding public method --- ux/grid/filter/NumericFilter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ux/grid/filter/NumericFilter.js b/ux/grid/filter/NumericFilter.js index 4ea544d..0af8793 100644 --- a/ux/grid/filter/NumericFilter.js +++ b/ux/grid/filter/NumericFilter.js @@ -53,7 +53,7 @@ Ext.define('Ext.ux.grid.filter.NumericFilter', { }, /** - * @private + * @public * Template method that is to return true if the filter * has enough configuration information to be activated. * @return {Boolean} From 575fd1e3bf38c1d3f3fd47147478c3ca1e071427 Mon Sep 17 00:00:00 2001 From: vjetteam Date: Thu, 26 Jul 2012 11:27:40 -0700 Subject: [PATCH 4/7] Update ux/grid/filter/ListFilter.js should not reduce visibility of overriding method --- ux/grid/filter/ListFilter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ux/grid/filter/ListFilter.js b/ux/grid/filter/ListFilter.js index 9a6bc6f..baef698 100644 --- a/ux/grid/filter/ListFilter.js +++ b/ux/grid/filter/ListFilter.js @@ -137,7 +137,7 @@ filter : [{"type":"list","value":"small,medium","field":"size"}] }, /** - * @private + * @public * Template method that is to return true if the filter * has enough configuration information to be activated. * @return {Boolean} From 437d188f24ec46b3859f0e7ac0468b568107d5cc Mon Sep 17 00:00:00 2001 From: vjetteam Date: Sun, 29 Jul 2012 14:02:42 -0700 Subject: [PATCH 5/7] Update ux/grid/filter/StringFilter.js isActivatable should be public since it is overriding public method --- ux/grid/filter/StringFilter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ux/grid/filter/StringFilter.js b/ux/grid/filter/StringFilter.js index 71b5a30..2b2c80e 100644 --- a/ux/grid/filter/StringFilter.js +++ b/ux/grid/filter/StringFilter.js @@ -80,7 +80,7 @@ Ext.define('Ext.ux.grid.filter.StringFilter', { }, /** - * @private + * @public * Template method that is to return true if the filter * has enough configuration information to be activated. * @return {Boolean} From f6d0ba85345689a7515f976bf1247810afafc788 Mon Sep 17 00:00:00 2001 From: "vjetteam@avantsoft.com" Date: Sun, 29 Jul 2012 14:13:05 -0700 Subject: [PATCH 6/7] adding eclipse files for easy import --- .buildpath | 9 +++++++++ .project | 17 +++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 .buildpath create mode 100644 .project diff --git a/.buildpath b/.buildpath new file mode 100644 index 0000000..807eeb5 --- /dev/null +++ b/.buildpath @@ -0,0 +1,9 @@ + + + + + + + + + diff --git a/.project b/.project new file mode 100644 index 0000000..75c1294 --- /dev/null +++ b/.project @@ -0,0 +1,17 @@ + + + SimpleTasks + + + + + + org.ebayopensource.vjet.eclipse.core.builder + + + + + + org.ebayopensource.vjet.core.nature + + From c9e39a74fc232d527130c9d3d47d7aeb24bd8865 Mon Sep 17 00:00:00 2001 From: "vjetteam@avantsoft.com" Date: Sun, 29 Jul 2012 14:53:43 -0700 Subject: [PATCH 7/7] Fixing jsdoc in example code --- ux/form/MultiSelect.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ux/form/MultiSelect.js b/ux/form/MultiSelect.js index 41e02d9..695c097 100644 --- a/ux/form/MultiSelect.js +++ b/ux/form/MultiSelect.js @@ -41,7 +41,7 @@ Ext.define('Ext.ux.form.MultiSelect', { */ /** - * @cfg {String} [appendOnly=false] True if the list should only allow append drops when drag/drop is enabled. + * @cfg {boolean} [appendOnly=false] True if the list should only allow append drops when drag/drop is enabled. * This is useful for lists which are sorted. */ appendOnly: false,