Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make proxivocab optional #240

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Add make proxivocab optional #240

merged 5 commits into from
Oct 10, 2022

Conversation

alihussainiam
Copy link
Member

closes #224

@alihussainiam alihussainiam added the enhancement New feature or request label Sep 27, 2022
JohannesLipp
JohannesLipp requested changes Sep 28, 2022
View reviewed changes
Copy link
Member

@JohannesLipp JohannesLipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you! Please just revert the deletions from the gitignore, so we can merge it, thanks!

.gitignore Show resolved Hide resolved
app/src/app/home-dashboard/vocabulary-list/vocabulary-list.component.ts Show resolved Hide resolved
@JohannesLipp JohannesLipp merged commit 9273800 into main Oct 10, 2022
@JohannesLipp JohannesLipp deleted the add-make-proxivocab-optional branch October 10, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesLipp JohannesLipp Awaiting requested review from JohannesLipp

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it optional if proxivocab details should be included in exports
2 participants
@alihussainiam @JohannesLipp