Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep popup open after clicking a link #103

Open
PetrP opened this issue Sep 9, 2022 · 0 comments
Open

Keep popup open after clicking a link #103

PetrP opened this issue Sep 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@PetrP
Copy link

PetrP commented Sep 9, 2022

Version 1.15.0 changed behavior of closing popup after clicking a stream.
In particular this window.close line.

Previous ClickBehavior.CreateTab behavior was that the new tab opened with (browser.tabs.create) active: true, but the popup stayed open so multiple steams could be clicked without reopening the popup. I used it to check multiple streams while still browsing gumbo popup before deciding who to watch, without loosing context inside of the popup.

It is possible to open stream with middle-click or with ctrl+click now, which has similar behavior of keeping popup open, but it's with active: false so the last opened stream is not visible, which is worse for my use case.

Closing popup probably makes sense for ClickBehavior.CreateWindow, not sure about ClickBehavior.CreateCurrentTab.

Would you consider reversing the behavior or making it configurable? If you're open to the change but you don't want to do it, then let me know which you prefer and I could make a pull request.

@PetrP PetrP added the enhancement New feature or request label Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant