Make GivensQ subtype AbstractQ, use API #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for putting this up @dkarrasch! The current version fails on Julia 1.6 because this error: Expression: F.Q \ Qx ≈ x
MethodError: no method matching lu!(::UpdatableQRFactorizations.GivensQ{Float64, Vector{LinearAlgebra.Givens{Float64}}}, ::Val{true}; check=true)Is there a more recent stable Julia version or a different fix that would support this? |
|
Ok, I fixed the issue on v1.6. Unfortunately, switching from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes this package future-proof for JuliaLang/julia#46196 and JuliaLang/julia#46874. This closes #4. Starting with the
AbstractQAPI in Julia v1.10, many need not be defined anymore. In fact, eltype promotion is then additionally handled by the fallback.