You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't really make sense to try and support so many different ways of giving e.g. a Neumann boundary condition - is_neumann_type(type) = type ∈ (:Neumann, :N, :neumann, "Neumann", "N", "neumann") - bit much! I should just define e.g.
abstract type AbstractBoundaryCondition endstruct Dirichlet <:AbstractBoundaryConditionendstruct Neumann <:AbstractBoundaryConditionendstruct DirichletDudt <:AbstractBoundaryConditionend# define is_dirichlet, etc.
and simply go from there. It might even make more sense to force users to instead provide vectors of BoundaryCondition types, e.g. maybe instead of providing functions, types, and params separately, we extend the above so that
It doesn't really make sense to try and support so many different ways of giving e.g. a Neumann boundary condition -
is_neumann_type(type) = type ∈ (:Neumann, :N, :neumann, "Neumann", "N", "neumann")
- bit much! I should just define e.g.and simply go from there. It might even make more sense to force users to instead provide vectors of
BoundaryCondition
types, e.g. maybe instead of providingfunctions
,types
, andparams
separately, we extend the above so thatI don't know if this better for the user experience, though. Maybe the former suggestion is fine.
The text was updated successfully, but these errors were encountered: